Use in-built ophyd-async code for checking smargon limits#1267
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1267 +/- ##
=======================================
Coverage 90.14% 90.14%
=======================================
Files 130 130
Lines 7830 7834 +4
=======================================
+ Hits 7058 7062 +4
Misses 772 772
🚀 New features to boost your workflow:
|
DominicOram
requested changes
Sep 15, 2025
DominicOram
left a comment
DominicOram
left a comment
Contributor
There was a problem hiding this comment.
Thanks, some comments in code
DominicOram
requested changes
Sep 17, 2025
DominicOram
left a comment
DominicOram
left a comment
Contributor
There was a problem hiding this comment.
Thanks. See comment in coed, happy to discuss in person if it doesn't make sense
DominicOram
requested changes
Sep 18, 2025
DominicOram
left a comment
DominicOram
left a comment
Contributor
There was a problem hiding this comment.
Great, thanks! Sorry, one more comment but basically there!
DominicOram
changed the title
DominicOram
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1263
Instructions to reviewer on how to test:
Checks for reviewer